Feature: Sim mode at runtime #5721

wxtim · 2023-09-06T15:19:01Z

Recheck simulation mode settings at runtime if a broadcast might have changed them. If it has, update these settings.

A waypoint on the road to skip mode.

~~Based upon #5712. Drafted until that is in.~~

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
Tests are included (or explain why tests are not needed).
CHANGES.md entry included if this is a change that can affect users
Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

cylc/flow/simulation.py

MetRonnie · 2024-03-07T11:59:45Z

Broadcasting execution retry delays does not cause a change when running in simulation mode
Also, in the Edit Runtime form, submission retry delays shows as 1 for some reason even though it is not set in flow.cylc

wxtim · 2024-03-08T09:36:27Z

Broadcasting execution retry delays does not cause a change when running in simulation mode

I cannot replicate this on the command line. Given the context of your comment I tried it from the gui and still couldn't replicate.

In fact some of the tests I've written should fail if that were the case.

Can you come up with a concrete example?

Replicated the submission retry delays thing. Pretty clueless about that though.

wxtim · 2024-03-08T09:50:36Z

cylc/flow/simulation.py


-        rtc['simulation']['simulated run length'] = sleep_sec
        rtc['submission retry delays'] = [1]


@MetRonnie Here is the cause of the value in the GUI's submission retry delays box. It also happens on master.

I think that it's probably as it's meant to be: In simulation mode, simulate retries after 1 second whatever the retry delay in live mode. However, I can't see that documented anywhere.

MetRonnie · 2024-03-08T11:14:54Z

Broadcasting execution retry delays does not cause a change when running in simulation mode

I cannot replicate this on the command line. Given the context of your comment I tried it from the gui and still couldn't replicate.

In fact some of the tests I've written should fail if that were the case.

Can you come up with a concrete example?

[scheduler]
    allow implicit tasks = True
[scheduling]
    initial cycle point = 2024
    runahead limit = P0
    [[graph]]
        P1M = foo => bar

[runtime]
    [[foo]]
        execution retry delays = 100*PT10S
        script = false
        [[[simulation]]]
            fail cycle points = all
            default run length = PT10S
            fail try 1 only = False

cylc broadcast sim-mode -n foo -s 'execution retry delays=20*PT1S'

But it still keeps saying

WARNING - [20240101T0000Z/foo waiting job:06 flows:1] retrying in PT10S

(The Edit Runtime form shows it correctly but it is not having an effect)

to allow non simulation settings to be modified and to avoid changing the itask.tdef.rtconfig.

wxtim · 2024-03-11T09:58:17Z

@MetRonnie - This is a good spot. I think that the broadcasts probably need to be applied in the TaskJobManager._simulation_submit_task_jobs method to ensure that we are broadcasting all task settings, not just those in [simulation]. I think you might also have found problems clearing broadcasts with things as they were, since I was changing the itask.tdef.rtconfig not a copy of it.

tests/integration/test_simulation.py

cylc/flow/simulation.py

Co-authored-by: Ronnie Dutta <[email protected]>

cylc/flow/simulation.py

changes.d/5721.feat.md

MetRonnie

Conflict resolution looks good

Co-authored-by: Hilary James Oliver <[email protected]>

wxtim · 2024-03-14T15:23:21Z

Conflict resolution looks good

Thank you @hjoliver

MetRonnie · 2024-03-14T17:31:57Z

Genuine test failure presumably: tests/f/modes/05-sim-trigger.t

hjoliver · 2024-03-14T22:31:46Z

I'm looking at the broken test -it's just a log-grep issue after cylc set changes to log messages... I've pushed a fix to the PR branch.

wxtim marked this pull request as draft September 6, 2023 15:19

wxtim requested review from oliver-sanders and hjoliver September 6, 2023 15:19

wxtim self-assigned this Sep 6, 2023

wxtim added this to the cylc-8.3.0 milestone Sep 6, 2023

wxtim commented Sep 7, 2023

View reviewed changes

cylc/flow/simulation.py Outdated Show resolved Hide resolved

hjoliver reviewed Sep 8, 2023

View reviewed changes

cylc/flow/simulation.py Outdated Show resolved Hide resolved

wxtim force-pushed the feature.sim_mode_at_runtime branch 3 times, most recently from fdc4cef to 09d4a36 Compare October 26, 2023 11:54

wxtim requested a review from hjoliver October 26, 2023 11:56

wxtim marked this pull request as ready for review October 26, 2023 11:57

wxtim force-pushed the feature.sim_mode_at_runtime branch from 09d4a36 to e8ca0c2 Compare October 26, 2023 12:14

wxtim marked this pull request as draft November 13, 2023 14:20

wxtim marked this pull request as ready for review November 13, 2023 14:44

oliver-sanders reviewed Nov 13, 2023

View reviewed changes

wxtim force-pushed the feature.sim_mode_at_runtime branch 2 times, most recently from 48f66fe to ee70398 Compare November 14, 2023 10:21

wxtim requested a review from oliver-sanders November 14, 2023 10:21

oliver-sanders mentioned this pull request Nov 14, 2023

dummy mode: subtract err-script from jobs #5820

Open

oliver-sanders reviewed Nov 14, 2023

View reviewed changes

cylc/flow/simulation.py Outdated Show resolved Hide resolved

wxtim marked this pull request as draft November 15, 2023 10:04

wxtim force-pushed the feature.sim_mode_at_runtime branch 6 times, most recently from d302f2d to 8aab09b Compare November 17, 2023 15:31

wxtim commented Nov 20, 2023

View reviewed changes

cylc/flow/simulation.py Show resolved Hide resolved

wxtim force-pushed the feature.sim_mode_at_runtime branch from 1491f42 to bcce93d Compare November 20, 2023 10:52

wxtim commented Mar 8, 2024

View reviewed changes

wxtim requested a review from MetRonnie March 8, 2024 10:04

Broadcast changes to simulated tasks in task_job_manager

b4f4bb1

to allow non simulation settings to be modified and to avoid changing the itask.tdef.rtconfig.

test that clearing broadcasts works for sim tasks

370d2b6

MetRonnie reviewed Mar 11, 2024

View reviewed changes

tests/integration/test_simulation.py Show resolved Hide resolved

cylc/flow/simulation.py Outdated Show resolved Hide resolved

cylc/flow/simulation.py Outdated Show resolved Hide resolved

wxtim and others added 4 commits March 11, 2024 13:40

Update cylc/flow/simulation.py

b9e1d15

Co-authored-by: Ronnie Dutta <[email protected]>

Update cylc/flow/simulation.py

b355ae2

Co-authored-by: Ronnie Dutta <[email protected]>

Update tests/integration/test_simulation.py

44abd5a

Co-authored-by: Ronnie Dutta <[email protected]>

fix test

cb064a0

wxtim requested a review from MetRonnie March 11, 2024 15:00

MetRonnie approved these changes Mar 12, 2024

View reviewed changes

Merge branch 'master' into feature.sim_mode_at_runtime

ef2fc58

hjoliver reviewed Mar 14, 2024

View reviewed changes

cylc/flow/simulation.py Outdated Show resolved Hide resolved

hjoliver reviewed Mar 14, 2024

View reviewed changes

changes.d/5721.feat.md Outdated Show resolved Hide resolved

MetRonnie approved these changes Mar 14, 2024

View reviewed changes

wxtim and others added 2 commits March 14, 2024 15:22

Update changes.d/5721.feat.md

6be7372

Co-authored-by: Hilary James Oliver <[email protected]>

Update cylc/flow/simulation.py

389a0be

Co-authored-by: Hilary James Oliver <[email protected]>

Fix func test, after update on master.

9186ad1

hjoliver force-pushed the feature.sim_mode_at_runtime branch from 1e5e806 to 9186ad1 Compare March 15, 2024 00:11

hjoliver approved these changes Mar 15, 2024

View reviewed changes

hjoliver merged commit a9becc2 into cylc:master Mar 15, 2024
27 checks passed

wxtim deleted the feature.sim_mode_at_runtime branch March 15, 2024 08:12

wxtim mentioned this pull request Mar 19, 2024

backport fix from #5712 #5927

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Sim mode at runtime #5721

Feature: Sim mode at runtime #5721

wxtim commented Sep 6, 2023 •

edited by oliver-sanders

Loading

MetRonnie commented Mar 7, 2024

wxtim commented Mar 8, 2024 •

edited

Loading

wxtim Mar 8, 2024 •

edited

Loading

MetRonnie commented Mar 8, 2024 •

edited

Loading

wxtim commented Mar 11, 2024 •

edited

Loading

MetRonnie left a comment

wxtim commented Mar 14, 2024

MetRonnie commented Mar 14, 2024

hjoliver commented Mar 14, 2024 •

edited

Loading


		rtc['simulation']['simulated run length'] = sleep_sec
		rtc['submission retry delays'] = [1]

Feature: Sim mode at runtime #5721

Feature: Sim mode at runtime #5721

Conversation

wxtim commented Sep 6, 2023 • edited by oliver-sanders Loading

MetRonnie commented Mar 7, 2024

wxtim commented Mar 8, 2024 • edited Loading

wxtim Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

MetRonnie commented Mar 8, 2024 • edited Loading

wxtim commented Mar 11, 2024 • edited Loading

MetRonnie left a comment

Choose a reason for hiding this comment

wxtim commented Mar 14, 2024

MetRonnie commented Mar 14, 2024

hjoliver commented Mar 14, 2024 • edited Loading

wxtim commented Sep 6, 2023 •

edited by oliver-sanders

Loading

wxtim commented Mar 8, 2024 •

edited

Loading

wxtim Mar 8, 2024 •

edited

Loading

MetRonnie commented Mar 8, 2024 •

edited

Loading

wxtim commented Mar 11, 2024 •

edited

Loading

hjoliver commented Mar 14, 2024 •

edited

Loading